Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SingleSpaceAfterConstructFixer - Add support for namespace #5727

Merged
merged 1 commit into from
May 25, 2021
Merged

SingleSpaceAfterConstructFixer - Add support for namespace #5727

merged 1 commit into from
May 25, 2021

Conversation

julienfalque
Copy link
Member

Closes #3728.

@coveralls
Copy link

coveralls commented May 21, 2021 •
edited

Coverage Status

Coverage remained the same at 91.559% when pulling 98a9bb6 on julienfalque:single-space-after-namespace into 9965811 on FriendsOfPHP:2.19.

@GrahamCampbell
Copy link
Contributor

Isn't changing the default a breaking change?

@julienfalque
Copy link
Member Author

Isn't changing the default a breaking change?

This already happened (e.g. #5406) but I would say it's fine here: it's part of the initial intent of this rule but was overlooked. So this PR is a an enhancement/bugfix rather than a new feature.

@kubawerlos kubawerlos added this to the 2.19.1 milestone May 24, 2021
@SpacePossum SpacePossum added the RTM Ready To Merge label May 25, 2021
@keradus keradus changed the title Add support for namespace to single_space_after_construct SingleSpaceAfterConstructFixer - Add support for namespace May 25, 2021
@keradus keradus removed the RTM Ready To Merge label May 25, 2021
@keradus keradus force-pushed the single-space-after-namespace branch from e5e0bd9 to 98a9bb6 Compare May 25, 2021 21:26
@keradus
Copy link
Member

keradus commented May 25, 2021

Thank you @julienfalque.

@keradus keradus merged commit fc67248 into PHP-CS-Fixer:2.19 May 25, 2021
@julienfalque julienfalque deleted the single-space-after-namespace branch May 25, 2021 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GrahamCampbell GrahamCampbell GrahamCampbell requested changes

@kubawerlos kubawerlos kubawerlos approved these changes

Assignees
No one assigned
Labels
kind/enhancement
Projects
None yet
Milestone
2.19.1
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@julienfalque @coveralls @GrahamCampbell @keradus @kubawerlos @SpacePossum