Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run migration rules on PHP 8 #5717

Merged
merged 1 commit into from
Jun 4, 2021
Merged

Run migration rules on PHP 8 #5717

merged 1 commit into from
Jun 4, 2021

Conversation

kubawerlos
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented May 15, 2021 •
edited

Coverage Status

Coverage remained the same at 91.561% when pulling 25e67e3 on kubawerlos:run-migration-rules-on-php-8 into 8d9a5e6 on FriendsOfPHP:2.19.

@kubawerlos kubawerlos marked this pull request as ready for review May 15, 2021 19:39
@kubawerlos
Copy link
Contributor Author

Return annotation for __sleep method could be removed when #5718 is merged.

Other changes looks acceptable to me, but I'm open to sugestions. WDYT @keradus as it was your idea to make this?

@keradus keradus added this to the 2.19.1 milestone Jun 4, 2021
@keradus
Copy link
Member

keradus commented Jun 4, 2021

Thank you @kubawerlos.

@keradus keradus merged commit 3180450 into PHP-CS-Fixer:2.19 Jun 4, 2021
@kubawerlos kubawerlos deleted the run-migration-rules-on-php-8 branch June 9, 2021 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keradus keradus keradus approved these changes

Assignees
No one assigned
Labels
kind/enhancement
Projects
None yet
Milestone
2.19.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kubawerlos @coveralls @keradus