Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix doc, "run-in" show-progress option is no longer present #5711

Merged
merged 1 commit into from
May 11, 2021

Conversation

mvorisek
Copy link
Contributor

@mvorisek mvorisek commented May 11, 2021

image

image

For some reasons, progress is correctly displayed with txt (default) format, but when dots progress optin is specified, the Legend line in the output is on a different place - why, please explain.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@keradus keradus added this to the 3.0.1 milestone May 11, 2021
@mvorisek
Copy link
Contributor Author

@keradus any idea about the note?

For some reasons, progress is correctly displayed with txt (default) format, but when dots progress optin is specified, the Legend line in the output is on a different place - why, please explain.

@keradus
Copy link
Member

keradus commented May 11, 2021

sorry @mvorisek , I failed to reproduce

Screenshot from 2021-05-11 23-41-51

@mvorisek
Copy link
Contributor Author

mvorisek commented May 11, 2021

see https://github.com/atk4/core/runs/2554188961?check_suite_focus=true and https://github.com/atk4/core/runs/2554072849?check_suite_focus=true

in these examples it is even swapped. I think the output consists of stdout and stderr and due buffering the outputs are not atomic

@keradus
Copy link
Member

keradus commented May 11, 2021

if you consider it worth time investing, please investigate and raise a fix-PR
for me, it looks like non-significant glitch that we can spend time better than fixing it, but I'm open to merge the fix if provided ;)

@keradus
Copy link
Member

keradus commented May 11, 2021

Thank you @mvorisek.

@keradus keradus merged commit ace3686 into PHP-CS-Fixer:3.0 May 11, 2021
@mvorisek
Copy link
Contributor Author

It caught my eyes and I was curious why dots progress option is not 1:1 implicit by verbose flag... I will not pursue the mixed streams output.

@mvorisek mvorisek deleted the patch-2 branch May 11, 2021 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants