PhpUnitNoExpectationAnnotationFixer - fix "expectedException" annotation with message below #5690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrahamCampbell
approved these changes
May 12, 2021
keradus
requested changes
May 13, 2021
| class MyTest extends TestCase | ||
| { | ||
| /** | ||
| */ |
There was a problem hiding this comment.
we should keep the original Testing stuff. comment
There was a problem hiding this comment.
This is because DocBlock build annotation in as "everything from @ to next @ (or comment end)" - should I change it there or only in this fixer?
There was a problem hiding this comment.
good point about annotation end.
then, let's use proper docblock in the test:
/**
* Testing stuff.
*
* @expectedException Foo\Bar
*/
There was a problem hiding this comment.
@keradus not really, this PR is about handling that case.
keradus
reviewed
May 13, 2021
…ion with message below
keradus
approved these changes
Jul 29, 2021
|
Thank you @kubawerlos. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: https://github.com/thephpleague/omnipay-common/blob/v3.0.5/tests/Omnipay/Common/Message/AbstractRequestTest.php#L167