- Sponsor
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PhpUnitNoExpectationAnnotationFixer - fix "expectedException" annotation with message below #5690
PhpUnitNoExpectationAnnotationFixer - fix "expectedException" annotation with message below #5690
Conversation
class MyTest extends TestCase | ||
{ | ||
/** | ||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should keep the original Testing stuff.
comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is because DocBlock
build annotation in as "everything from @
to next @
(or comment end)" - should I change it there or only in this fixer?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good point about annotation end.
then, let's use proper docblock in the test:
/**
* Testing stuff.
*
* @expectedException Foo\Bar
*/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@keradus not really, this PR is about handling that case.
…ion with message below
Thank you @kubawerlos. |
Reference: https://github.com/thephpleague/omnipay-common/blob/v3.0.5/tests/Omnipay/Common/Message/AbstractRequestTest.php#L167