UX: Display deprecations to end-user #5674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keradus
added a commit
that referenced
this pull request
May 13, 2021
…ues (PetrHeinz) This PR was squashed before being merged into the 2.19 branch. Discussion ---------- Utils - save only unique deprecations to avoid memory issues With the #5674 merged, we have run into exhaustion of allowed memory pretty quickly, see https://github.com/shopsys/shopsys/pull/2308/checks?check_run_id=2511509379 Even though it would be better for us to fix all the deprecations, and we definitely plan to do it in the future, it will be rather time consuming and we would like to use the newer version in the meantime. I propose to save the deprecation message only if it's unique. Because `array_unique` is called on the result afterwards, I see no issues with this approach. Commits ------- b9a839e Utils - save only unique deprecations to avoid memory issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
simplified approach of #3699