DX: code grooming #5664
Merged
DX: code grooming #5664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubawerlos
reviewed
Apr 28, 2021
src/Tokenizer/Token.php
Outdated
| @@ -87,7 +87,7 @@ public function __construct($token) | |||
| } else { | |||
| throw new \InvalidArgumentException(sprintf( | |||
| 'Cannot recognize input value as valid Token prototype, got "%s".', | |||
| \is_object($token) ? \get_class($token) : \gettype($token) | |||
| \get_class($token) | |||
There was a problem hiding this comment.
Haha, I've tried the same and got the same results you can see in failed test.
In PHPDoc it is stated $token is array or string, so PHPStan claims this else is unreachable, when in fact it is. We will be able typehint this only in PHP 8+.
kubawerlos
reviewed
Apr 28, 2021
src/Tokenizer/Token.php
Outdated
| @@ -87,7 +87,7 @@ public function __construct($token) | |||
| } else { | |||
| throw new \InvalidArgumentException(sprintf( | |||
| 'Cannot recognize input value as valid Token prototype, got "%s".', | |||
| \is_object($token) ? \get_class($token) : \gettype($token) | |||
| \get_class($token) | |||
There was a problem hiding this comment.
Suggested change
| \get_class($token) | |
| \is_object($token) ? \get_class($token) : \gettype($token) // @phpstan-ignore-line this is not unreachable |
kubawerlos
approved these changes
Apr 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.