Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeAlternationTransformer - fix for "array" type in type alternation #5660

Merged
merged 1 commit into from Apr 28, 2021
Merged

TypeAlternationTransformer - fix for "array" type in type alternation #5660

merged 1 commit into from Apr 28, 2021

Conversation

kubawerlos
Copy link
Contributor

Fixes #5659

@coveralls
Copy link

coveralls commented Apr 25, 2021

Coverage Status

Coverage remained the same at 91.902% when pulling e362435 on kubawerlos:fix_VisibilityRequiredFixer into c2f6aa3 on FriendsOfPHP:2.18.

@kubawerlos kubawerlos changed the title VisibilityRequiredFixer - fix for "array|null" type TypeAlternationTransformer - fix for "array" type in type alternation Apr 25, 2021
@kubawerlos kubawerlos marked this pull request as ready for review April 25, 2021 06:39
@kubawerlos kubawerlos added this to the 2.18.7 milestone Apr 25, 2021
@keradus
Copy link
Member

keradus commented Apr 28, 2021

Thank you @kubawerlos.

@keradus keradus merged commit 93f1df5 into PHP-CS-Fixer:2.18 Apr 28, 2021
@kubawerlos kubawerlos deleted the fix_VisibilityRequiredFixer branch April 28, 2021 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when using union types array|null on public property
3 participants