Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SingleLineThrowFixer - fix for match expression #5654

Merged
merged 1 commit into from Apr 24, 2021
Merged

SingleLineThrowFixer - fix for match expression #5654

merged 1 commit into from Apr 24, 2021

Conversation

kubawerlos
Copy link
Contributor

@kubawerlos kubawerlos commented Apr 21, 2021 •
edited

Fixes #5653

@lyrixx do you have time for review?

@coveralls
Copy link

coveralls commented Apr 21, 2021 •
edited

Coverage Status

Coverage remained the same at 91.902% when pulling b11b6b1 on kubawerlos:fix_SingleLineThrowFixer_match into 4353039 on FriendsOfPHP:2.18.

@kubawerlos kubawerlos marked this pull request as draft April 21, 2021 20:16
@kubawerlos kubawerlos marked this pull request as ready for review April 23, 2021 13:20
@lyrixx
Copy link
Contributor

lyrixx commented Apr 23, 2021

LGTM. Thanks 💛

@keradus keradus added this to the 2.18.7 milestone Apr 24, 2021
@keradus
Copy link
Member

keradus commented Apr 24, 2021

Thank you @kubawerlos.

@keradus keradus merged commit fe2e08f into PHP-CS-Fixer:2.18 Apr 24, 2021
@kubawerlos kubawerlos deleted the fix_SingleLineThrowFixer_match branch April 24, 2021 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keradus keradus keradus approved these changes

Assignees
No one assigned
Labels
kind/bug
Projects
None yet
Milestone
2.18.7
Development

Successfully merging this pull request may close these issues.

Match expression + Exception does not play well
4 participants
@kubawerlos @coveralls @lyrixx @keradus