GroupImportFixer - fix breaking code when fixing root classes #5598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Leprechaunz you don't want to add that test in integration tests, but in |
kubawerlos
reviewed
Apr 6, 2021
| use Foo\Bar; | ||
| use Foo\Baz; | ||
| use ReflectionClass; | ||
| use ReflectionMethod; |
There was a problem hiding this comment.
Let's add one more test when all imported classes have leading \.
There was a problem hiding this comment.
Good point, thanks
kubawerlos
approved these changes
Apr 6, 2021
keradus
changed the title
keradus
force-pushed
the
fix-group-import
branch
from
2849fa9
to
486b598
Compare
|
Thanks for fixing this bug @Leprechaunz. |
|
Thanks @Leprechaunz 😍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5574