Tokens - fix for checking block edges #5597
Merged
+50
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubawerlos
commented
Apr 12, 2021
keradus
reviewed
Apr 12, 2021
src/Tokenizer/Tokens.php
Outdated
| @@ -50,7 +50,7 @@ class Tokens extends \SplFixedArray | |||
| /** | |||
| * Cache of block edges. Any change in collection will invalidate it. | |||
| * | |||
| * @var array<int, int> | |||
| * @var array<string, array<int, int>> | |||
| */ | |||
| private $blockEndCache = []; | |||
There was a problem hiding this comment.
Suggested change
| private $blockEndCache = []; | |
| private $blockEndCache = [ | |
| 'start_to_end' = [], | |
| 'end_to_start' = [], | |
| ]; |
There was a problem hiding this comment.
to avoid autovivification. pls fix other places too
|
Thank you @kubawerlos. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found this when investigating #5533.
This loop was problematic,
)was passed tofindBlockEndand it was returning index of(and thus loop was infinitive.See separate commits for better understanding if needed.