Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DX: add test to make sure SingleSpaceAfterConstructFixer runs before FunctionDeclarationFixer #5571

Merged
merged 1 commit into from
Apr 3, 2021
Merged

DX: add test to make sure SingleSpaceAfterConstructFixer runs before FunctionDeclarationFixer #5571

merged 1 commit into from
Apr 3, 2021

Conversation

kubawerlos
Copy link
Contributor

To prevent regression reported in #5568.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.849% when pulling eb3f1c1 on kubawerlos:dx_add_test_to_make_sure_SingleSpaceAfterConstructFixer_runs_before_FunctionDeclarationFixer into 61b9090 on FriendsOfPHP:2.18.

kbond
kbond approved these changes Mar 22, 2021
View reviewed changes
Copy link

@kbond kbond left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed this fixes #5568 (or I guess #5563 actually fixes).

@kubawerlos kubawerlos added this to the 2.18.5 milestone Mar 29, 2021
@keradus
Copy link
Member

keradus commented Apr 3, 2021

Thank you @kubawerlos.

@keradus keradus merged commit 6511119 into PHP-CS-Fixer:2.18 Apr 3, 2021
@kubawerlos kubawerlos deleted the dx_add_test_to_make_sure_SingleSpaceAfterConstructFixer_runs_before_FunctionDeclarationFixer branch April 3, 2021 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbond kbond kbond approved these changes

@GrahamCampbell GrahamCampbell GrahamCampbell approved these changes

Assignees
No one assigned
Labels
topic/tests
Projects
None yet
Milestone
2.18.5
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@kubawerlos @coveralls @keradus @kbond @GrahamCampbell