VisibilityRequiredFixer - support type alternation for properties #5439
+24
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keradus
added a commit
that referenced
this pull request
Jan 18, 2021
This PR was squashed before being merged into the 2.17 branch. Discussion ---------- Add PHP8 integration test ref #4702 There are ~3~ 4 cases still crashing in the spec files: - [x] nullsafe operator -> PHP 8.0.1 to be released at 7th - [x] attributes #5406 - [x] union types for method parameters #5405 - [x] union types for class properties #5439 I also found the following issues that I raised as separated PRs: - [x] ~#5396~ -> #5397 - [x] ~#5400~ -> #5404 Commits ------- 324929f Add PHP8 integration test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
needed for PHP8