Skip to content

NullableTypeTransformer - constructor property promotion support #5404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 30, 2020
Merged

NullableTypeTransformer - constructor property promotion support #5404

merged 1 commit into from
Dec 30, 2020
+85 −1

Conversation

Wirone
Copy link
Member

@Wirone Wirone commented Dec 30, 2020

Fixes #5401

@Wirone Wirone force-pushed the improved-nullable-type-transformer branch from a16068d to 17bd460 Compare December 30, 2020 11:42
@Wirone Wirone mentioned this pull request Dec 30, 2020
Closed
@coveralls
Copy link

coveralls commented Dec 30, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.005%) to 91.369% when pulling 3554339 on Wirone:improved-nullable-type-transformer into 98dd819 on FriendsOfPHP:2.17.

@keradus keradus added this to the 2.17.4 milestone Dec 30, 2020
@SpacePossum SpacePossum added kind/enhancement topic/PHP8.0 Related to features available in PHP 8.0+ labels Dec 30, 2020
@SpacePossum SpacePossum changed the title Nullable type transformer with property promotion support NullableTypeTransformer- constructor property promotion support Dec 30, 2020
@SpacePossum SpacePossum added the RTM Ready To Merge label Dec 30, 2020
@SpacePossum
Copy link
Contributor

@Wirone thanks for reporting and fixing, looking good!

Could you add your example from #5401 as a test to TernaryOperatorSpacesFixerTest (with @requires PHP 8.0) ?

keradus
keradus approved these changes Dec 30, 2020
View reviewed changes
Copy link
Member

@keradus keradus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really nice contribution!

@keradus keradus changed the title NullableTypeTransformer- constructor property promotion support NullableTypeTransformer - constructor property promotion support Dec 30, 2020
@keradus keradus removed the RTM Ready To Merge label Dec 30, 2020
@keradus keradus force-pushed the improved-nullable-type-transformer branch from 8e8c196 to 209f898 Compare December 30, 2020 15:46
@keradus
Copy link
Member

keradus commented Dec 30, 2020

Thank you @Wirone.

@keradus keradus merged commit bb6ee85 into PHP-CS-Fixer:2.17 Dec 30, 2020
@Wirone Wirone deleted the improved-nullable-type-transformer branch December 30, 2020 15:51
@Wirone
Copy link
Member Author

Wirone commented Dec 30, 2020

@keradus happy to hear that! And thank you for the great tool 👍

@keradus keradus mentioned this pull request Jan 6, 2021
Merged
6 tasks
keradus added a commit that referenced this pull request Jan 18, 2021
@keradus
minor #5399 Add PHP8 integration test (keradus)
f209e6d 
This PR was squashed before being merged into the 2.17 branch.

Discussion
----------

Add PHP8 integration test

ref #4702

There are ~3~ 4 cases still crashing in the spec files:
- [x] nullsafe operator -> PHP 8.0.1 to be released at 7th
- [x] attributes #5406
- [x] union types for method parameters #5405
- [x] union types for class properties #5439

I also found the following issues that I raised as separated PRs:
- [x] ~#5396~ -> #5397
- [x] ~#5400~ -> #5404

Commits
-------

324929f Add PHP8 integration test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienfalque julienfalque

@keradus keradus

Assignees
No one assigned
Labels
kind/enhancement topic/PHP8.0 Related to features available in PHP 8.0+
Projects
None yet
Milestone
2.17.4
Development

Successfully merging this pull request may close these issues.

TernaryOperatorSpacesFixer incompatible with nullable constructor property promotion
5 participants
@Wirone @coveralls @SpacePossum @keradus @julienfalque