Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PhpdocTagTypeFixer: Do not modify array shapes #5395

Merged
merged 2 commits into from
May 13, 2021
Merged

PhpdocTagTypeFixer: Do not modify array shapes #5395

merged 2 commits into from
May 13, 2021

Conversation

localheinz
Copy link
Member

This PR

  • adds a failing test that shows that the PhpdocTagTypeFixer modifies array shapes

💁‍♂️ For reference, see

Perhaps @SpacePossum can take a look?

@localheinz localheinz mentioned this pull request Dec 27, 2020
Closed
3 tasks
@keradus keradus marked this pull request as draft December 28, 2020 12:03
@kubawerlos kubawerlos mentioned this pull request Jan 20, 2021
Closed
@keradus keradus changed the base branch from 2.17 to 2.18 January 24, 2021 21:33
@keradus keradus changed the base branch from 2.18 to 2.19 May 3, 2021 22:11
@coveralls
Copy link

Coverage Status

Coverage increased (+0.002%) to 91.532% when pulling cfc28fd on localheinz:fix/phpdoc-tag-type into 714e192 on FriendsOfPHP:2.19.

@julienfalque
Copy link
Member

Fixed :)

@julienfalque julienfalque marked this pull request as ready for review May 7, 2021 11:11
@julienfalque julienfalque added this to the 2.19.1 milestone May 7, 2021
@keradus keradus changed the title [PhpdocTagTypeFixer] Do not modify array shapes PhpdocTagTypeFixer: Do not modify array shapes May 13, 2021
@keradus
Copy link
Member

keradus commented May 13, 2021

Thank you @localheinz.

@keradus keradus merged commit 25f9db1 into PHP-CS-Fixer:2.19 May 13, 2021
@julienfalque julienfalque mentioned this pull request Jun 9, 2021
Closed
@ruudk ruudk mentioned this pull request Jul 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kubawerlos kubawerlos kubawerlos approved these changes

Assignees
No one assigned
Labels
kind/bug
Projects
None yet
Milestone
2.19.1
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@localheinz @coveralls @julienfalque @keradus @kubawerlos