Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SingleLineCommentStyleFixer- run before NoUselessReturnFixer #5385

Merged
merged 1 commit into from Dec 23, 2020
Merged

SingleLineCommentStyleFixer- run before NoUselessReturnFixer #5385

merged 1 commit into from Dec 23, 2020

Conversation

kubawerlos
Copy link
Contributor

Fixes #5382

Ping @mvorisek for review (as a reporter of bug).

@mvorisek
Copy link
Contributor

Ping @mvorisek for review (as a reporter of bug).

LGTM, thanks @kubawerlos!

@SpacePossum SpacePossum changed the title Make single_line_comment_style runs after no_useless_return SingleLineCommentStyleFixer- run before NoUselessReturnFixer Dec 22, 2020
@SpacePossum SpacePossum added this to the 2.17.3 milestone Dec 22, 2020
@SpacePossum SpacePossum added the RTM Ready To Merge label Dec 22, 2020
@keradus keradus removed the RTM Ready To Merge label Dec 23, 2020
@keradus
Copy link
Member

keradus commented Dec 23, 2020

Thank you @kubawerlos.

@keradus keradus merged commit 1b81c27 into PHP-CS-Fixer:2.17 Dec 23, 2020
@kubawerlos kubawerlos deleted the prio_no_useless_return_single_line_comment_style branch December 23, 2020 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GrahamCampbell GrahamCampbell GrahamCampbell approved these changes

Assignees
No one assigned
Labels
kind/bug
Projects
None yet
Milestone
2.17.3
Development

Successfully merging this pull request may close these issues.

Fix comments priority (single_line_comment_style)
5 participants
@kubawerlos @mvorisek @keradus @GrahamCampbell @SpacePossum