NativeFunctionInvocationFixer - BacktickToShellExecFixer - fix integration test #5096
+1
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubawerlos
approved these changes
Aug 7, 2020
|
The last fail is because on 3.0 we set the error logging here; Now the setting is not loaded by PHPUnit so it runs with other values than we expected the app with. We could make a bootstrap file for PHPUnit, but maybe there is a more easy/better way to set the error reporting level in PHPUnit config? (@ see https://github.com/symfony/phpunit-bridge/blob/v5.1.3/Legacy/SymfonyTestsListenerTrait.php#L339 for why the error reporting settings causes the tests to fail) |
|
Thank you @SpacePossum. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default configuration for the
NativeFunctionInvocationFixerwas changed on 3.0 making this priority test fail on it.