Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NoEmptyCommentFixer - handle multiline comments #4996

Merged
merged 1 commit into from Jun 14, 2020
Merged

NoEmptyCommentFixer - handle multiline comments #4996

merged 1 commit into from Jun 14, 2020

Conversation

kubawerlos
Copy link
Contributor

No description provided.

@julienfalque
Copy link
Member

Shouldn't no_empty_comment remove multiline comments as well? This would remove the priority issue.

@kubawerlos kubawerlos changed the title SingleLineCommentStyleFixer - must run before NoEmptyCommentFixer NoEmptyCommentFixer - handle multiline comments Jun 8, 2020
@SpacePossum SpacePossum added this to the 2.15.8 milestone Jun 8, 2020
@SpacePossum SpacePossum added RTM Ready To Merge and removed RTM Ready To Merge labels Jun 10, 2020
@SpacePossum
Copy link
Contributor

Thank you @kubawerlos.

@SpacePossum SpacePossum merged commit 520e931 into PHP-CS-Fixer:2.15 Jun 14, 2020
@kubawerlos kubawerlos deleted the add_single_line_comment_style,no_empty_comment.test branch June 14, 2020 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants