Skip to content

NativeConstantInvocation - Add "PHP_INT_SIZE" to SF rule set #4947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 23, 2020
Merged

NativeConstantInvocation - Add "PHP_INT_SIZE" to SF rule set #4947

merged 1 commit into from
May 23, 2020
+1 −0

Conversation

kubawerlos
Copy link
Member

As requested by @nicolas-grekas.

Added as a feature because it is change request.

julienfalque
julienfalque approved these changes May 8, 2020
View reviewed changes
Copy link
Member

@julienfalque julienfalque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would still merge it into 2.15 but 👍

drupol
drupol approved these changes May 8, 2020
View reviewed changes
Copy link
Contributor

@drupol drupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@SpacePossum SpacePossum added the RTM Ready To Merge label May 12, 2020
@SpacePossum SpacePossum added this to the 2.17.0 milestone May 13, 2020
@SpacePossum SpacePossum changed the title Add "PHP_INT_SIZE" to "native_constant_invocation" in Symfony rule set configuration NativeConstantInvocation - Add "PHP_INT_SIZE" to SF rule set May 17, 2020
@SpacePossum
Copy link
Contributor

Thank you @kubawerlos.

@SpacePossum SpacePossum merged commit a27982e into PHP-CS-Fixer:master May 23, 2020
@SpacePossum SpacePossum removed the RTM Ready To Merge label May 23, 2020
@kubawerlos kubawerlos deleted the update-native_constant_invocation_for_sf_ruleset branch May 23, 2020 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drupol drupol

@julienfalque julienfalque

@SpacePossum SpacePossum

Assignees
No one assigned
Labels
kind/feature
Projects
None yet
Milestone
2.17.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kubawerlos @SpacePossum @drupol @julienfalque