PhpdocSeparationFixer - fix regression with lack of next line #4911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keradus
changed the title
keradus
force-pushed
the
2.16_regression_fix
branch
from
cb364b3
to
323c594
Compare
|
Desc should have included "Closes #4869.". |
|
sorry, didn't saw that PR. |
|
I sent a PR which fixed the bug, but I wasn't sure of the exact case that reproduced it. |
|
I only had a non-isolated example, which was no good to use. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added utest without fix that crashes on CI: https://travis-ci.org/github/FriendsOfPHP/PHP-CS-Fixer/jobs/673531958