Fix conflict between header_comment and declare_strict_types #4895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienfalque
force-pushed
the
fix-header-declare-conflict
branch
from
9a884f5
to
73528e8
Compare
GrahamCampbell
approved these changes
Mar 26, 2020
kubawerlos
approved these changes
Mar 31, 2020
The priority test is to make sure no old behaviour gets broken the misc one is to make sure we fix the bug. Plus tests for the header coment fixer itself if chosen to go that way
keradus
force-pushed
the
fix-header-declare-conflict
branch
from
73528e8
to
ee98411
Compare
|
Thank you @julienfalque. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3467.
/cc @BackEndTea