FunctionsAnalyzer - better isGlobalFunctionCall detection #4846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubawerlos
reviewed
Feb 27, 2020
| @@ -75,7 +75,7 @@ protected function applyFix(\SplFileInfo $file, Tokens $tokens) | |||
| { | |||
| $functionsAnalyzer = new FunctionsAnalyzer(); | |||
|
|
|||
| foreach ($tokens as $index => $token) { | |||
| for ($index = \count($tokens) - 1; $index > 0; --$index) { | |||
There was a problem hiding this comment.
Without the change the fixer fails on some PHP versions, but not on all. I didn't find the root cause for this difference. However iterating over the tokens set from start till end using foreach while manipulating it (in front of you) typically doesn't end well, but again, I didn't get to the bottom of it...
SpacePossum
deleted the
2_15_FunctionsAnalyzer_isGlobalFunctionCall_fix
branch
This was referenced Feb 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3051
Replaces #4251