BracesFixer - fix invalid code generation on alternative syntax #4813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienfalque
approved these changes
Feb 14, 2020
|
What about |
|
it is here; https://github.com/FriendsOfPHP/PHP-CS-Fixer/pull/4813/files#diff-6ee2b7ebb0faee78657d4e8d3fb3e10dR5313 but happy to add more tests! good find, thanks! code and tests updated |
kubawerlos
approved these changes
Feb 16, 2020
julienfalque
approved these changes
Feb 16, 2020
SpacePossum
added a commit
that referenced
this pull request
Feb 18, 2020
…ntax (SpacePossum) This PR was squashed before being merged into the 2.15 branch (closes #4813). Discussion ---------- BracesFixer - fix invalid code generation on alternative syntax Fixes #4811 Basically this skips some edge cases when using alternative syntax. For now I don't want to add a lot of logic to support this case fully as we are splitting this fixer in the future anyway. Secondly we don't support alternative syntax in a lot of cases in the project. For those interested; `BracesFixer::findStatementEnd` doesn't find the correct index for some of the alternative syntax expressions (see utests) Commits ------- fd5a1cf BracesFixer - fix invalid code generation on alternative syntax
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4811
Basically this skips some edge cases when using alternative syntax. For now I don't want to add a lot of logic to support this case fully as we are splitting this fixer in the future anyway. Secondly we don't support alternative syntax in a lot of cases in the project.
For those interested;
BracesFixer::findStatementEnddoesn't find the correct index for some of the alternative syntax expressions (see utests)