Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TokensAnalyzer::isUnarySuccessorOperator fix for array curly braces #4804

Merged
merged 1 commit into from
Feb 12, 2020
Merged

TokensAnalyzer::isUnarySuccessorOperator fix for array curly braces #4804

merged 1 commit into from
Feb 12, 2020

Conversation

SpacePossum
Copy link
Contributor

No description provided.

@SpacePossum SpacePossum added this to the 2.15.6 milestone Feb 12, 2020
@julienfalque
Copy link
Member

Fixes #4657?

Side note: please avoid mixing unrelated changes in a single PR, it tends to make review harder (more changes to read, and need to understand how some changes are (not) related to what the PR claims to do).

@SpacePossum
Copy link
Contributor Author

I cannot reproduce that issue so cannot say if this fixes it, but it is likely.

For now I keep adding small stuff to any PR when I think is not worth the trouble doing all the paper work for. Yes, I know the processes and conventions etc., but I'm trading all that theory for practical velocity as I think that is what this project needs way more than having a very clean history on the smallest changes, like here additional test cases.
If someone requests me to split up a PR I will always consider it, but I'm not going to do it upfront as most of the time it just creates more work without any real benefit or appreciation.

@SpacePossum SpacePossum added the RTM Ready To Merge label Feb 12, 2020
SpacePossum added a commit that referenced this pull request Feb 12, 2020
…y braces (SpacePossum)

This PR was merged into the 2.15 branch.

Discussion
----------

TokensAnalyzer::isUnarySuccessorOperator fix for array curly braces

Commits
-------

d53ad32 TokensAnalyzer::isUnarySuccessorOperator fix for array curly braces
@SpacePossum SpacePossum merged commit d53ad32 into PHP-CS-Fixer:2.15 Feb 12, 2020
@SpacePossum SpacePossum removed the RTM Ready To Merge label Feb 12, 2020
@SpacePossum SpacePossum deleted the 2_15_TokensAnalyzer_isUnarySuccessorOperator_fix branch February 12, 2020 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants