Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NoSuperfluousPhpdocTagsFixer - fix for really big PHPDoc #4783

Merged
merged 2 commits into from
Feb 11, 2020
Merged

NoSuperfluousPhpdocTagsFixer - fix for really big PHPDoc #4783

merged 2 commits into from
Feb 11, 2020

Conversation

kubawerlos
Copy link
Contributor

@kubawerlos kubawerlos commented Feb 5, 2020

Replaces #4659

Ping @mvorisek as author of original PR (and in fact bug reporter) and @julienfalque as original author of the fixer, for review.

@mvorisek
Copy link
Contributor

mvorisek commented Feb 5, 2020

@kubawerlos legit work!

@julienfalque julienfalque added the RTM Ready To Merge label Feb 8, 2020
@SpacePossum SpacePossum added this to the 2.15.6 milestone Feb 11, 2020
@SpacePossum
Copy link
Contributor

Thank you @kubawerlos.

SpacePossum added a commit that referenced this pull request Feb 11, 2020
…ubawerlos, mvorisek)

This PR was merged into the 2.15 branch.

Discussion
----------

NoSuperfluousPhpdocTagsFixer - fix for really big PHPDoc

Replaces #4659

Ping @mvorisek as author of original PR (and in fact bug reporter) and @julienfalque as original author of the fixer, for review.

Commits
-------

d2220f7 Make regex compatible with large input/subject
a3ee659 NoSuperfluousPhpdocTagsFixer - fix RegEx for really big PHPDoc - test
@SpacePossum SpacePossum merged commit d2220f7 into PHP-CS-Fixer:2.15 Feb 11, 2020
@SpacePossum SpacePossum removed the RTM Ready To Merge label Feb 11, 2020
@kubawerlos kubawerlos deleted the fix_no_superfluous_phpdoc_tags_regex branch February 11, 2020 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants