Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run Travis CI on stable PHP 7.4 #4691

Merged
merged 1 commit into from
Jan 6, 2020
Merged

Run Travis CI on stable PHP 7.4 #4691

merged 1 commit into from
Jan 6, 2020

Conversation

kubawerlos
Copy link
Contributor

@kubawerlos kubawerlos commented Dec 8, 2019

  • "Static Code Analysis" and "Fast Test" to be run on PHP 7.4
  • each standard job to be run on different PHP (previously "Collect coverage" and "With migration rules" were run on the same PHP version)
  • nightly instead of 7.4snapshot as assertUpcomingPhpVersionIsCoveredByCiJob
  • allow nightly to fail
  • update humbug/box due to it's dependency nikic/iter having the problem with PHP 7.4

Needs https://travis-ci.community/t/some-extensions-are-missing-in-php-7-4-0-zip-gmp-sodium/6320 to be fixed

@kubawerlos kubawerlos changed the title DX: run Travis CI on stable PHP 7.4 [WIP] DX: run Travis CI on stable PHP 7.4 Dec 8, 2019
.travis.yml Outdated Show resolved Hide resolved
@julienfalque julienfalque added this to the 2.15.6 milestone Jan 6, 2020
@julienfalque julienfalque changed the title [WIP] DX: run Travis CI on stable PHP 7.4 DX: run Travis CI on stable PHP 7.4 Jan 6, 2020
@julienfalque julienfalque changed the title DX: run Travis CI on stable PHP 7.4 Run Travis CI on stable PHP 7.4 Jan 6, 2020
@SpacePossum SpacePossum added the RTM Ready To Merge label Jan 6, 2020
@julienfalque
Copy link
Member

Thank you @kubawerlos.

julienfalque added a commit that referenced this pull request Jan 6, 2020
This PR was merged into the 2.15 branch.

Discussion
----------

Run Travis CI on stable PHP 7.4

- "Static Code Analysis" and "Fast Test" to be run on PHP 7.4
- each standard job to be run on different PHP (previously "Collect coverage" and "With migration rules" were run on the same PHP version)
- `nightly` instead of `7.4snapshot` as `assertUpcomingPhpVersionIsCoveredByCiJob`
- allow nightly to fail
- update `humbug/box` due to it's dependency `nikic/iter` having the [problem](https://github.com/nikic/iter/blob/v1.6.0/src/iter.fn.php#L3) with PHP 7.4

Needs https://travis-ci.community/t/some-extensions-are-missing-in-php-7-4-0-zip-gmp-sodium/6320 to be fixed

Commits
-------

9f93a51 DX: run Travis CI on stable PHP 7.4
@julienfalque julienfalque merged commit 9f93a51 into PHP-CS-Fixer:2.15 Jan 6, 2020
@julienfalque julienfalque removed the RTM Ready To Merge label Jan 6, 2020
@kubawerlos kubawerlos deleted the run-travis-on-php74 branch January 6, 2020 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants