Improve Symfony 5 compatibility #4685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can confirm this fixes the issue. Here is my reproducer: https://github.com/kbond/php-cs-fixer-2.16.1-reproducer |
julienfalque
approved these changes
Dec 3, 2019
kbond
approved these changes
Dec 3, 2019
This was referenced Dec 6, 2019
SpacePossum
approved these changes
Dec 18, 2019
GrahamCampbell
approved these changes
Dec 21, 2019
|
Any chance of merging and tagging a new version with this soon? The PR is opened for almost a month already and it is blocking us from properly testing our package in CI (with different Symfony and PHP versions) -> trikoder/oauth2-bundle#141 |
|
Hello do you know when this fix will be released ? |
|
Thank you @keradus. |
julienfalque
added a commit
that referenced
this pull request
Jan 1, 2020
This PR was merged into the 2.15 branch. Discussion ---------- Improve Symfony 5 compatibility Closes #4684 one can install contract on his own, even if he is using Sf version that does not rely on contracts, for that, we need to check if actually Sf component relies on contract, not only the fact that contract exists. TODO: - [x] look for other places when we check that contract exists and nothing more (edit by @julienfalque: only found one in the related test, not sure it's worth the hassle) Commits ------- 03f6fd5 Better Sf5 compatibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4684
one can install contract on his own, even if he is using Sf version that does not rely on contracts,
for that, we need to check if actually Sf component relies on contract, not only the fact that contract exists.
TODO: