Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling array type declaration in properties #4682

Merged

Conversation

julienfalque
Copy link
Member

Fixes #4680.

@julienfalque julienfalque added the RTM Ready To Merge label Dec 1, 2019
julienfalque added a commit that referenced this pull request Dec 9, 2019
…lque)

This PR was merged into the 2.15 branch.

Discussion
----------

Fix handling array type declaration in properties

Fixes #4680.

Commits
-------

fe3ead2 Fix handling array type declaration in properties
@julienfalque julienfalque merged commit fe3ead2 into PHP-CS-Fixer:2.15 Dec 9, 2019
@julienfalque julienfalque deleted the fix-properties-array-type branch December 9, 2019 18:29
@julienfalque julienfalque removed the RTM Ready To Merge label Dec 9, 2019
@janvernieuwe
Copy link

This is a really annoying issue, when is this going to be released?

@edmandiesamonte
Copy link

@julienfalque any update on this? Was this released?

@julienfalque
Copy link
Member Author

Yes it was.

@edmandiesamonte
Copy link

@julienfalque is there a need to change anything in the config because it is still happening on my local
php-cs-fixer:

$ ./vendor/bin/php-cs-fixer -V
PHP CS Fixer 2.16.1 Yellow Bird by Fabien Potencier and Dariusz Ruminski

PHP

PHP 7.4.2 (cli) (built: Jan 22 2020 06:30:58) ( NTS )
Copyright (c) The PHP Group
Zend Engine v3.4.0, Copyright (c) Zend Technologies
    with Zend OPcache v7.4.2, Copyright (c), by Zend Technologies

Diff:

   1) athena/app/Core/Events/Subscriber.php
      ---------- begin diff ----------
--- Original
+++ New
@@ -9,5 +9,7 @@
 
 class Subscriber
 {
-    private array $map = [];
+    private array
+
+ $map = [];
 }

      ----------- end diff -----------

@julienfalque
Copy link
Member Author

The fix was released in versions 2.15.6 and 2.16.2. Your are using version 2.16.1 which does not contain the fix patch.

@edmandiesamonte
Copy link

Works! Thanks, @julienfalque! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants