-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: add info about "-vv..." #4644
Conversation
Content is looking good, only checks to fix. |
I'm wondering if the current changes are really helpful. I mean those options are standard Symfony options and quite common amongst CLI tools in general. Also one can already find this information with Maybe something more helpful would be to actually add details about what each verbosity level shows/hides? |
Just because these are default options, does not mean that the docs should not contain it. And yes, some extra information are maybe helpful. I think this is the relevant part?: https://github.com/FriendsOfPHP/PHP-CS-Fixer/blob/master/src/Console/Output/ErrorOutput.php#L55 |
please, check the contributing guidelines. |
c34bdf4
to
f83c81c
Compare
@keradus CIs fixed. I did not change any source code, so I thought that the failing tests are not related to these changes. |
👍 |
I still think it would be nice to not only list the different options and their verbosity level but also say what each level of verbosity will output, i.e. if verbosity is at least [level], it will show [info]. |
I agree with you, @julienfalque unfortunately, nobody is working on it and I believe it's better to merge small improvement than not merge any improvement (while awaiting for big improvement to be proposed). |
Thank you @voku. |
merged into LTS |
This change is