Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: add info about "-vv..." #4644

Merged
merged 1 commit into from
Mar 2, 2020
Merged

Docs: add info about "-vv..." #4644

merged 1 commit into from
Mar 2, 2020

Conversation

voku
Copy link
Contributor

@voku voku commented Nov 14, 2019

This change is Reviewable

README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
@kubawerlos
Copy link
Contributor

Content is looking good, only checks to fix.

@julienfalque
Copy link
Member

I'm wondering if the current changes are really helpful. I mean those options are standard Symfony options and quite common amongst CLI tools in general. Also one can already find this information with php-cs-fixer fix --help.

Maybe something more helpful would be to actually add details about what each verbosity level shows/hides?

@voku
Copy link
Contributor Author

voku commented Nov 15, 2019

Just because these are default options, does not mean that the docs should not contain it.

And yes, some extra information are maybe helpful. I think this is the relevant part?: https://github.com/FriendsOfPHP/PHP-CS-Fixer/blob/master/src/Console/Output/ErrorOutput.php#L55

@keradus
Copy link
Member

keradus commented Nov 24, 2019

please, check the contributing guidelines.
as you can see, all CIs are failing.

@voku voku force-pushed the patch-1 branch 2 times, most recently from c34bdf4 to f83c81c Compare November 25, 2019 21:07
@voku
Copy link
Contributor Author

voku commented Nov 25, 2019

@keradus CIs fixed. I did not change any source code, so I thought that the failing tests are not related to these changes.

@SpacePossum
Copy link
Contributor

👍
maybe best to target lowest stable so we've less differences over the branches?

@julienfalque
Copy link
Member

I still think it would be nice to not only list the different options and their verbosity level but also say what each level of verbosity will output, i.e. if verbosity is at least [level], it will show [info].

@keradus keradus changed the title add info about "-vv..." Docs: add info about "-vv..." Mar 2, 2020
@keradus
Copy link
Member

keradus commented Mar 2, 2020

I agree with you, @julienfalque

unfortunately, nobody is working on it and I believe it's better to merge small improvement than not merge any improvement (while awaiting for big improvement to be proposed).

@keradus keradus added this to the 2.15.6 milestone Mar 2, 2020
@keradus keradus changed the base branch from master to 2.15 March 2, 2020 21:22
@keradus
Copy link
Member

keradus commented Mar 2, 2020

Thank you @voku.

@keradus keradus merged commit f9fd467 into PHP-CS-Fixer:2.15 Mar 2, 2020
@keradus
Copy link
Member

keradus commented Mar 2, 2020

merged into LTS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants