FullyQualifiedStrictTypesFixer - Ignore partial class names which look like FQCNs #4630
+69
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
localheinz
force-pushed
the
fix/fully-qualified-strict-types
branch
2 times, most recently
from
8a1dd4f to
f09f402
Compare
GrahamCampbell
approved these changes
Nov 10, 2019
|
Is this ready to be merged? |
localheinz
force-pushed
the
fix/fully-qualified-strict-types
branch
from
c7d23ab to
cbfa444
Compare
|
This looks like a solid fix to me 👍 Just wondering, maybe we could apply it to the |
localheinz
force-pushed
the
fix/fully-qualified-strict-types
branch
from
cbfa444 to
ad2dca6
Compare
|
Can you explain what you mean? |
localheinz
force-pushed
the
fix/fully-qualified-strict-types
branch
3 times, most recently
from
fb29fdc to
4a368f8
Compare
|
checking the code again Im not sure what I was thinking 😅 |
SpacePossum
approved these changes
Jan 6, 2020
julienfalque
approved these changes
Jan 6, 2020
SpacePossum
force-pushed
the
fix/fully-qualified-strict-types
branch
from
bd58838 to
0785928
Compare
|
Thank you @localheinz. |
SpacePossum
added a commit
that referenced
this pull request
Jan 7, 2020
… which look like FQCNs (localheinz, SpacePossum) This PR was squashed before being merged into the 2.15 branch (closes #4630). Discussion ---------- FullyQualifiedStrictTypesFixer - Ignore partial class names which look like FQCNs This PR * [x] adds a failing test case * [x] ignores types when they are not references relative to the root namespace Commits ------- 0785928 FullyQualifiedStrictTypesFixer - Ignore partial class names which look like FQCNs
|
Thank you, @GrahamCampbell, @julienfalque, and @SpacePossum! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR