PhpdocToPropertyTypeFixer - introduction

[julienfalque]

This PR includes #4591 and depends on #4593 which should both be merged first.

[SpacePossum]

👍 looking very nice :)

some minors I found;
the fixer crashes on abstract function like;

abstract public function getFoo(): string;

which seems to be because;

            if ($tokens[$index]->isGivenKind(T_FUNCTION)) {
                $index = $tokens->getNextTokenOfKind($index, ['{']);

secondly, when there are a of candidate the fixer doesn't catch them all in the first run. Test sample;

<?php

class ActivityLog
{
    /**
     * @var int
     */
    private $id;

    /**
     * @var string
     */
    private $id1;

    /**
     * @var string
     */
    private $id2;

    /**
     * @var int
     */
    private $id3;

    /**
     * @var string
     */
    private $id4;

    /**
     * @var string
     */
    private $id5;

    /**
     * @var string
     */
    private $id6;

    /**
     * @var string
     */
    private $id7;

    /**
     * @var int
     */
    private $id8;

    /**
     * @var string
     */
    private $id9;

    /**
     * @var int|null
     */
    private $id410;
}

[julienfalque]

Thanks for the test cases, I fixed them :)

[duxthefux]

+1 on that. Any estimation on when this can be merged?

[kubawerlos]

@julienfalque can you split this PR to one adding new fixers and 2nd (targeted to 2.15) with refactoring of DocBlock classes?

[julienfalque]

@kubawerlos Is #4591 what you want (this PR depends on it)? It currently targets 2.16 though.

[kubawerlos]

@julienfalque yes, it is. Shame on me.

[kubawerlos]

Sorry for the conflicts @julienfalque - can you solve them? I believe thee review would be quite straightforward here.

[julienfalque]

Rebased #4591 and here, please review :)

[GrahamCampbell]

I'd actually question if this belongs in php-cs-fixer. It's more a job for a refactoring tool like Rector, rather than a code style fixing tool.

[Slamdunk]

I'd actually question if this belongs in php-cs-fixer. It's more a job for a refactoring tool like Rector, rather than a code style fixing tool.

We already to a lot of refactoring in PHP-CS-Fixer. Moreover, PHP_CodeSniffer already does it: https://github.com/slevomat/coding-standard/blob/master/SlevomatCodingStandard/Sniffs/TypeHints/PropertyTypeHintSniff.php#L260-L296

[GrahamCampbell]

I don't think we need to add more. It only adds more upgrading work every time a new version of PHP comes out.

[Slamdunk]

I understand your point: it would be good for maintenance to have a fixer tool decoupled from PHP version, and maybe other one (like Rector) for the upgrade path.

But we are a bit late for such approach, aren't we?

[SpacePossum]

@julienfalque please rebase and after that RTM 👍

[julienfalque]

@SpacePossum #4591 should be merged first.

[coveralls]

Coverage increased (+0.02%) to 91.596% when pulling 0382be5 on julienfalque:phpdoc-to-property-type-fixer into 24e9391 on FriendsOfPHP:master.

[keradus]

Thank you @julienfalque.

[julienfalque]

Thank you @keradus!

[AJenbo]

thanks this will be useful