Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CommentsAnalyzer - fix for declare before header comment #4377

Merged
merged 1 commit into from
Jan 7, 2020
Merged

CommentsAnalyzer - fix for declare before header comment #4377

merged 1 commit into from
Jan 7, 2020

Conversation

kubawerlos
Copy link
Contributor

No description provided.

@SpacePossum
Copy link
Contributor

can you add a test for:

<?php

/**
 * 1
 */

declare(strict_types=1);

/**
 * 2
 */

namespace App\Controller\CMS\Capsule;

/**
 * 3
 */

final class Foo{}

so it show only the first PHPDoc is considered a header?

php-cs-fixer Outdated Show resolved Hide resolved
@keradus keradus changed the base branch from 2.12 to 2.15 September 4, 2019 11:07
@julienfalque julienfalque added this to the 2.15.6 milestone Jan 6, 2020
@SpacePossum SpacePossum added the RTM Ready To Merge label Jan 6, 2020
@SpacePossum
Copy link
Contributor

Thank you @kubawerlos.

SpacePossum added a commit that referenced this pull request Jan 7, 2020
…(kubawerlos)

This PR was squashed before being merged into the 2.15 branch (closes #4377).

Discussion
----------

CommentsAnalyzer - fix for declare before header comment

Commits
-------

b27f23f CommentsAnalyzer - fix for declare before header comment
@SpacePossum SpacePossum merged commit b27f23f into PHP-CS-Fixer:2.15 Jan 7, 2020
@SpacePossum SpacePossum removed the RTM Ready To Merge label Jan 7, 2020
@kubawerlos kubawerlos deleted the fix/comment-analyzer-declare branch January 7, 2020 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants