Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.3] PhpUnitDedicateAssertFixer - support PHP 7.3 #4211

Merged
merged 1 commit into from Jan 4, 2019
Merged

[7.3] PhpUnitDedicateAssertFixer - support PHP 7.3 #4211

merged 1 commit into from Jan 4, 2019

Conversation

kubawerlos
Copy link
Contributor

No description provided.

@SpacePossum
Copy link
Contributor

please see SpacePossum@3d7875c as well

@SpacePossum
Copy link
Contributor

please add:

             [
                 '<?php $this->assertInternalType(\'array\', $a,);',
                 '<?php $this->assertTrue(is_array($a,),);',
             ],

as these are fixed through a different path

@SpacePossum SpacePossum added this to the 2.12.6 milestone Jan 2, 2019
@keradus keradus mentioned this pull request Jan 2, 2019
20 tasks
@kubawerlos
Copy link
Contributor Author

@SpacePossum I've added your test cases

@SpacePossum
Copy link
Contributor

please add this test as well:

            [
                '<?php $this->assertNan($y  , );',
                '<?php $this->assertTrue(is_nan($y)  , );',
            ],

I think your change aims to remove the trailing , or at least remove the trailing spacing, but it seems not. Maybe removing the trailing space before removing the , token is the cause?

I'm happy with results anyway, but like to capture the behavior of the fixer in this test case :)

@keradus
Copy link
Member

keradus commented Jan 4, 2019

Thank you @kubawerlos.

@keradus keradus merged commit 7c567e8 into PHP-CS-Fixer:2.12 Jan 4, 2019
keradus added a commit that referenced this pull request Jan 4, 2019
…erlos)

This PR was merged into the 2.12 branch.

Discussion
----------

[7.3] PhpUnitDedicateAssertFixer - support PHP 7.3

Commits
-------

7c567e8 [7.3] PhpUnitDedicateAssertFixer - support PHP 7.3
@kubawerlos kubawerlos deleted the fix-php73-phpunit-dedicate branch January 4, 2019 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants