[7.3] ErrorSuppressionFixer - support PHP 7.3 #4202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keradus
reviewed
Jan 1, 2019
|
|
||
| return $tokens[$tokens->getPrevMeaningfulToken($end)]->equals([T_STRING, 'E_USER_DEPRECATED']); | ||
| $prevIndex = $tokens->getPrevMeaningfulToken($endBraceIndex); |
There was a problem hiding this comment.
i;m really sad to see this change over and over again :(
There was a problem hiding this comment.
yeah :( it's similar to checking for leading \ in functions/classes
keradus
reviewed
Jan 1, 2019
| @@ -11,7 +11,6 @@ PHP 7.3 test. | |||
| "multiline_whitespace_before_semicolons": true, | |||
| "native_function_invocation": {"include": ["get_class"]}, | |||
| "php_unit_test_case_static_method_calls": {"call_type": "this"}, | |||
| "silenced_deprecation_error": true, | |||
|
Thank you @kubawerlos. |
SpacePossum
added a commit
that referenced
this pull request
Jan 2, 2019
This PR was merged into the 2.12 branch. Discussion ---------- [7.3] ErrorSuppressionFixer - support PHP 7.3 Handles also `SilencedDeprecationErrorFixer` and it's proxy to `ErrorSuppressionFixer`. Commits ------- e7aa9fc ErrorSuppressionFixer - support PHP 7.3
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handles also
SilencedDeprecationErrorFixerand it's proxy toErrorSuppressionFixer.