Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.3] MethodChainingIndentationFixer - add tests for PHP 7.3 #4199

Merged
merged 1 commit into from Jan 4, 2019
Merged

[7.3] MethodChainingIndentationFixer - add tests for PHP 7.3 #4199

merged 1 commit into from Jan 4, 2019

Conversation

kubawerlos
Copy link
Contributor

No description provided.

@keradus keradus added this to the 2.12.6 milestone Jan 2, 2019
@keradus keradus mentioned this pull request Jan 2, 2019
Closed
20 tasks
@keradus
Copy link
Member

keradus commented Jan 2, 2019

Travis is failing on 7.3

@kubawerlos
Copy link
Contributor Author

Fixed, multiline_whitespace_before_semicolons update affected integration test.

SpacePossum
SpacePossum approved these changes Jan 2, 2019
View reviewed changes
Copy link
Contributor

@SpacePossum SpacePossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when the test are green

@keradus keradus added RTM Ready To Merge and removed RTM Ready To Merge labels Jan 4, 2019
@keradus
Copy link
Member

keradus commented Jan 4, 2019

Thank you @kubawerlos.

@keradus keradus merged commit f49510a into PHP-CS-Fixer:2.12 Jan 4, 2019
keradus added a commit that referenced this pull request Jan 4, 2019
@keradus
minor #4199 [7.3] MethodChainingIndentationFixer - add tests for PHP …
bbbaa57 
…7.3 (kubawerlos)

This PR was merged into the 2.12 branch.

Discussion
----------

[7.3] MethodChainingIndentationFixer - add tests for PHP 7.3

Commits
-------

f49510a [7.3] MethodChainingIndentationFixer - add tests for PHP 7.3
@kubawerlos kubawerlos deleted the fix-php73-method-chaining-indent branch January 4, 2019 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keradus keradus keradus left review comments

@SpacePossum SpacePossum SpacePossum approved these changes

Assignees
No one assigned
Labels
kind/enhancement
Projects
None yet
Milestone
2.12.6
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kubawerlos @keradus @SpacePossum