PhpdocTypesFixer - allow for configuration #4019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @localheinz, cc @sebastianbergmann |
keradus
force-pushed
the
2.12_types_types
branch
from
c7dc15b
to
3394dfc
Compare
|
Thanks @keradus. |
SpacePossum
added a commit
that referenced
this pull request
Oct 18, 2018
This PR was merged into the 2.12 branch. Discussion ---------- PhpdocTypesFixer - allow for configuration eg, `callback` alias type was in charge before 5.4, later it's not used. eg `boolean`, usually may mean `bool` primitive, but sometimes it is a real custom class... while for most cases it shall be fixed, there are few cases when not. let's make this configurable ref sebastianbergmann/phpunit#3327 Commits ------- 3394dfc PhpdocTypesFixer - allow for configuration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eg,
callbackalias type was in charge before 5.4, later it's not used.eg
boolean, usually may meanboolprimitive, but sometimes it is a real custom class...while for most cases it shall be fixed, there are few cases when not. let's make this configurable
ref sebastianbergmann/phpunit#3327