Run HeaderCommentFixer after NoBlankLinesAfterPhpdocFixer #3987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SpacePossum
approved these changes
Nov 1, 2018
|
Thanks for this PR @StanAngeloff! Looking good so far, not sure what is/was up with circleci, lets see what it does now |
keradus
force-pushed
the
improvement-change-header-comment-priority
branch
from
ca349a2
to
da3bdea
Compare
|
Thank you @StanAngeloff. |
keradus
added a commit
that referenced
this pull request
Nov 28, 2018
…StanAngeloff) This PR was merged into the 2.12 branch. Discussion ---------- Run HeaderCommentFixer after NoBlankLinesAfterPhpdocFixer This ensures the output is stable when `HeaderCommentFixer` is configured with `["separate" => "bottom", "commentType" => "PHPDoc"]` and the target file has no `namespace` or `declare()` construct. Test case added, test suite passes. Commits ------- da3bdea Run HeaderCommentFixer after NoBlankLinesAfterPhpdocFixer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures the output is stable when
HeaderCommentFixeris configured with["separate" => "bottom", "commentType" => "PHPDoc"]and the target file has nonamespaceordeclare()construct.Test case added, test suite passes.