Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Circle CI v2 yml #3950

Merged
merged 1 commit into from Aug 10, 2018
Merged

Circle CI v2 yml #3950

merged 1 commit into from Aug 10, 2018

Conversation

siad007
Copy link
Contributor

@siad007 siad007 commented Jul 29, 2018

Added a new circle ci version 2 config file.
Note that i could not tested this but maybe it is still helpful for you.

Related to #3874 .

@keradus
Copy link
Member

keradus commented Jul 29, 2018

Hi @siad007 ! Very first - big thanks for support on this topic! Looks promising, indeed!

Sadly, for PHP CS Fixer, the whole point of using CircleCI is to run tests on MacOS (same as we use Travis for Linux and AppVeyor for Windows)

While using docker image instead of build php using brew on host OS directly, we are not testing on MacOS anymore:

ker@dus:/tmp λ docker run -it --rm circleci/php:7.2 php -r "print_r(posix_uname()['sysname']);"
Linux

Can you update your PR please? thanks !

@siad007
Copy link
Contributor Author

siad007 commented Jul 29, 2018

@keradus No problem it would be easy to rewrite this to go by brew as it was before - but still interesting enough that tests were failing! I will change it to mac asap.

@kubawerlos
Copy link
Contributor

@siad007 can you also add an entry .circleci/ export-ignore to .gitattributes file?

@siad007
Copy link
Contributor Author

siad007 commented Jul 29, 2018

@keradus @kubawerlos added your changes right now and it seems ok. But do you have an idea why the former linux based config produced the test failures?

@kubawerlos
Copy link
Contributor

@siad007 in .circleci/config.yml in line 22 there are trailing whitespaces.

.gitattributes Outdated
@@ -20,6 +20,7 @@ box.json export-ignore
check_trailing_spaces.sh export-ignore
phpmd.xml export-ignore
phpunit.xml.dist export-ignore
.circleci export-ignore
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move it a little bit up to keep alphabetic order? And also add / after the directory name to point it is directory?

@siad007
Copy link
Contributor Author

siad007 commented Jul 29, 2018

Ah and btw 8.2 is not supported any longer so i updated to xcode 9.0.

@SpacePossum SpacePossum requested a review from keradus July 30, 2018 06:48
@keradus keradus added this to the 2.12.3 milestone Jul 30, 2018
@keradus keradus added RTM Ready To Merge topic/tests and removed topic/tests labels Aug 1, 2018
@keradus keradus removed the RTM Ready To Merge label Aug 10, 2018
@keradus
Copy link
Member

keradus commented Aug 10, 2018

Thank you @siad007.

@keradus keradus merged commit 9573da3 into PHP-CS-Fixer:2.12 Aug 10, 2018
keradus added a commit that referenced this pull request Aug 10, 2018
This PR was squashed before being merged into the 2.12 branch (closes #3950).

Discussion
----------

Circle CI v2 yml

Added a new circle ci version 2 config file.
Note that i could not tested this but maybe it is still helpful for you.

Related to #3874 .

Commits
-------

9573da3 Circle CI v2 yml
@siad007 siad007 deleted the siad007-patch-1 branch August 11, 2018 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants