New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Circle CI v2 yml #3950
Circle CI v2 yml #3950
Conversation
Hi @siad007 ! Very first - big thanks for support on this topic! Looks promising, indeed! Sadly, for PHP CS Fixer, the whole point of using CircleCI is to run tests on MacOS (same as we use Travis for Linux and AppVeyor for Windows) While using docker image instead of build php using brew on host OS directly, we are not testing on MacOS anymore:
Can you update your PR please? thanks ! |
@keradus No problem it would be easy to rewrite this to go by brew as it was before - but still interesting enough that tests were failing! I will change it to mac asap. |
@siad007 can you also add an entry |
@keradus @kubawerlos added your changes right now and it seems ok. But do you have an idea why the former linux based config produced the test failures? |
@siad007 in |
.gitattributes
Outdated
@@ -20,6 +20,7 @@ box.json export-ignore | |||
check_trailing_spaces.sh export-ignore | |||
phpmd.xml export-ignore | |||
phpunit.xml.dist export-ignore | |||
.circleci export-ignore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we move it a little bit up to keep alphabetic order? And also add /
after the directory name to point it is directory?
Ah and btw 8.2 is not supported any longer so i updated to xcode 9.0. |
5d43da9
to
67531f5
Compare
67531f5
to
9573da3
Compare
Thank you @siad007. |
Added a new circle ci version 2 config file.
Note that i could not tested this but maybe it is still helpful for you.
Related to #3874 .