Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeAnalysis - Fix iterable not being detected as a reserved type #3921

Merged

Conversation

ntzm
Copy link
Contributor

@ntzm ntzm commented Jul 14, 2018

No description provided.

@ntzm ntzm closed this Jul 14, 2018
@ntzm ntzm reopened this Jul 14, 2018
@ntzm
Copy link
Contributor Author

ntzm commented Jul 14, 2018

Reopened because travis timed out

@@ -33,7 +33,7 @@
'bool',
'callable',
'int',
'iteratable',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

buahahahaha

@keradus keradus changed the title Fix iterable not being detected as a reserved type in TypeAnalysis TypeAnalysis - Fix iterable not being detected as a reserved type Jul 14, 2018
@keradus keradus added this to the 2.12.3 milestone Jul 14, 2018
@keradus keradus added RTM Ready To Merge and removed RTM Ready To Merge labels Jul 14, 2018
@keradus
Copy link
Member

keradus commented Jul 20, 2018

Thank you @ntzm.

@keradus keradus merged commit b4b4486 into PHP-CS-Fixer:2.12 Jul 20, 2018
keradus added a commit that referenced this pull request Jul 20, 2018
…d type (ntzm)

This PR was merged into the 2.12 branch.

Discussion
----------

TypeAnalysis - Fix iterable not being detected as a reserved type

Commits
-------

b4b4486 Fix iterable not being detected as a reserved type in TypeAnalysis
@ntzm ntzm deleted the fix-iterable-not-counted-as-reserved branch July 20, 2018 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants