NoUnreachableDefaultArgumentValueFixer - remove null for nullable typehints
#3914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like the idea 👍 Travis needs to be fixed (provided case is running on too low PHP engine, it has to run on high enough) |
keradus
approved these changes
Jul 13, 2018
keradus
force-pushed
the
nounreachabledefault-nullable
branch
from
07b21bc
to
dad732f
Compare
|
Thank you @gharlan. |
keradus
added a commit
that referenced
this pull request
Jul 20, 2018
…for nullable typehints (gharlan, keradus) This PR was squashed before being merged into the 2.13-dev branch (closes #3914). Discussion ---------- NoUnreachableDefaultArgumentValueFixer - remove `null` for nullable typehints #3883 (comment) Commits ------- dad732f NoUnreachableDefaultArgumentValueFixer - remove `null` for nullable typehints
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3883 (comment)