PhpdocVarWithoutNameFixer - fix for properties only #3911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntzm
suggested changes
Jul 13, 2018
dmvdbrugge
force-pushed
the
3112-phpdoc_var_without_name
branch
from
c90a246
to
d7771e8
Compare
keradus
requested changes
Jul 13, 2018
tests/Fixtures/Integration/misc/phpdoc_to_comment,phpdoc_var_without_name.test
Outdated
Show resolved
Hide resolved
dmvdbrugge
force-pushed
the
3112-phpdoc_var_without_name
branch
4 times, most recently
from
30e75d1
to
c5abd1a
Compare
ntzm
suggested changes
Jul 16, 2018
dmvdbrugge
force-pushed
the
3112-phpdoc_var_without_name
branch
from
c5abd1a
to
a640dc9
Compare
kubawerlos
reviewed
Jul 16, 2018
dmvdbrugge
force-pushed
the
3112-phpdoc_var_without_name
branch
from
a640dc9
to
de4baf2
Compare
dmvdbrugge
force-pushed
the
3112-phpdoc_var_without_name
branch
from
de4baf2
to
3b826a5
Compare
kubawerlos
reviewed
Aug 7, 2018
tests/Fixtures/Integration/misc/phpdoc_to_comment,phpdoc_var_without_name.test
Show resolved
Hide resolved
ntzm
approved these changes
Aug 14, 2018
dmvdbrugge
force-pushed
the
3112-phpdoc_var_without_name
branch
from
3b826a5
to
62d3f08
Compare
dmvdbrugge
force-pushed
the
3112-phpdoc_var_without_name
branch
from
62d3f08
to
5ee9aea
Compare
SpacePossum
reviewed
Dec 27, 2018
dmvdbrugge
force-pushed
the
3112-phpdoc_var_without_name
branch
from
41b35ec
to
ec59373
Compare
SpacePossum
approved these changes
Jan 11, 2019
|
Can this be merged? |
|
@kubawerlos or members/maintainer please review/approve as well |
|
Another month passed... Can someone please take a look? @keradus? |
julienfalque
approved these changes
Jun 20, 2019
dmvdbrugge
force-pushed
the
3112-phpdoc_var_without_name
branch
from
f085882
to
b02ec73
Compare
|
I rebased onto latest 2.12 Travis fails on something completely unrelated to this PR 😕 |
keradus
force-pushed
the
3112-phpdoc_var_without_name
branch
from
28ec4e9
to
bc9cfd3
Compare
keradus
requested changes
Aug 31, 2019
tests/Fixtures/Integration/misc/phpdoc_to_comment,phpdoc_var_without_name.test
Show resolved
Hide resolved
julienfalque
reviewed
Sep 1, 2019
|
ping @dmvdbrugge |
SpacePossum
force-pushed
the
3112-phpdoc_var_without_name
branch
3 times, most recently
from
6282288
to
64e4b00
Compare
SpacePossum
force-pushed
the
3112-phpdoc_var_without_name
branch
from
64e4b00
to
60c5ca1
Compare
|
I've update the PR and added some tests and made other minor adjustments. Thanks @dmvdbrugge for all the work, thanks to the reviewers as well! |
|
Thank you @SpacePossum for the merge and additional work. I apologise for being a bit unresponsive on this 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #3112