Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StrictParamFixer - fix edge case #3908

Merged
merged 1 commit into from Aug 10, 2018
Merged

StrictParamFixer - fix edge case #3908

merged 1 commit into from Aug 10, 2018

Conversation

kubawerlos
Copy link
Contributor

No matter how stupid, this is valid PHP syntax, so should be fixed, right?

@SpacePossum
Copy link
Contributor

I would say so, the current return statement seems off.
Having a test case with a file containing multiple blocked-namespaces which include function imports will show more issues around this.

@SpacePossum SpacePossum added this to the 2.12.3 milestone Aug 1, 2018
@keradus keradus changed the title Fix: StrictParamFixer - edge case StrictParamFixer - fix edge case Aug 10, 2018
@keradus
Copy link
Member

keradus commented Aug 10, 2018

Thank you @kubawerlos.

@keradus keradus merged commit 29c6aad into PHP-CS-Fixer:2.12 Aug 10, 2018
keradus added a commit that referenced this pull request Aug 10, 2018
@keradus
bug #3908 StrictParamFixer - fix edge case (kubawerlos)
499211a 
This PR was squashed before being merged into the 2.12 branch (closes #3908).

Discussion
----------

StrictParamFixer - fix edge case

No matter how stupid, this is valid PHP syntax, so should be fixed, right?

Commits
-------

29c6aad StrictParamFixer - fix edge case
@kubawerlos kubawerlos deleted the fix/strict-param-fixer-edge-case branch August 10, 2018 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SpacePossum SpacePossum SpacePossum approved these changes

Assignees
No one assigned
Labels
kind/bug
Projects
None yet
Milestone
2.12.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kubawerlos @SpacePossum @keradus