Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DX: cleanup - remove special treatment for PHP <5.6 #3903

Merged
merged 1 commit into from Jul 12, 2018
Merged

DX: cleanup - remove special treatment for PHP <5.6 #3903

merged 1 commit into from Jul 12, 2018

Conversation

kubawerlos
Copy link
Contributor

No description provided.

keradus
keradus reviewed Jul 11, 2018
View reviewed changes
tests/Fixer/ClassNotation/SelfAccessorFixerTest.php Outdated
@@ -83,7 +83,6 @@ public function provideFixCases()
'<?php class Foo { function bar() { new Foo\Baz(); } }',
],
[
// PHP < 5.4 compatibility: "self" is not available in closures
'<?php class Foo { function bar() { function ($a = Foo::BAZ) { new Foo(); }; } }',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so, self::BAZ ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oki doki, updated test case and fixer.

@keradus keradus added this to the 2.12.3 milestone Jul 11, 2018
@SpacePossum SpacePossum added kind/cleanup RTM Ready To Merge labels Jul 12, 2018
@SpacePossum
Copy link
Contributor

Thanks @kubawerlos.

@SpacePossum SpacePossum merged commit 46a95e6 into PHP-CS-Fixer:2.12 Jul 12, 2018
SpacePossum added a commit that referenced this pull request Jul 12, 2018
@SpacePossum
minor #3903 DX: cleanup - remove special treatment for PHP <5.6 (kuba…
901debd 
…werlos)

This PR was squashed before being merged into the 2.12 branch (closes #3903).

Discussion
----------

DX: cleanup - remove special treatment for PHP <5.6

Commits
-------

46a95e6 DX: cleanup - remove special treatment for PHP <5.6
@SpacePossum SpacePossum removed the RTM Ready To Merge label Jul 12, 2018
@kubawerlos kubawerlos deleted the cleanup/remove-exception-for-below-php-56 branch July 12, 2018 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keradus keradus keradus approved these changes

Assignees
No one assigned
Labels
kind/cleanup
Projects
None yet
Milestone
2.12.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kubawerlos @SpacePossum @keradus