Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FunctionsAnalyzer - false positive for constant and function definition #3895

Merged
merged 1 commit into from Jul 10, 2018
Merged

FunctionsAnalyzer - false positive for constant and function definition #3895

merged 1 commit into from Jul 10, 2018

Conversation

kubawerlos
Copy link
Contributor

Class is @internal so rename is fine.

@keradus keradus added this to the 2.12.3 milestone Jul 9, 2018
@SpacePossum SpacePossum added the RTM Ready To Merge label Jul 10, 2018
@SpacePossum
Copy link
Contributor

Thanks @kubawerlos.

@SpacePossum SpacePossum merged commit 673de4a into PHP-CS-Fixer:2.12 Jul 10, 2018
SpacePossum added a commit that referenced this pull request Jul 10, 2018
@SpacePossum
bug #3895 FunctionsAnalyzer - false positive for constant and functio…
5a8c190 
…n definition (kubawerlos)

This PR was squashed before being merged into the 2.12 branch (closes #3895).

Discussion
----------

FunctionsAnalyzer - false positive for constant and function definition

Class is `@internal` so rename is fine.

Commits
-------

673de4a FunctionsAnalyzer - false positive for constant and function definition
@SpacePossum SpacePossum removed the RTM Ready To Merge label Jul 10, 2018
@kubawerlos kubawerlos deleted the bugfix/function-analyzer branch July 10, 2018 14:52
@kubawerlos kubawerlos mentioned this pull request Jul 10, 2018
Merged
SpacePossum added a commit that referenced this pull request Jul 11, 2018
@SpacePossum
minor #3897 DX: FunctionsAnalyzer - simplifying return expression (ku…
1e6392d 
…bawerlos)

This PR was merged into the 2.12 branch.

Discussion
----------

DX: FunctionsAnalyzer - simplifying return expression

Just noticed after #3895 that it could be done a bit simpler.

Commits
-------

ffd3932 DX: simplifying return expression in FunctionsAnalyzer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keradus keradus keradus approved these changes

Assignees
No one assigned
Labels
kind/bug
Projects
None yet
Milestone
2.12.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kubawerlos @SpacePossum @keradus