Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NoSuperfluousPhpdocTagsFixer - handle null in every position #3884

Conversation

dmvdbrugge
Copy link
Contributor

… instead of last only.

This fixes #3849

@dmvdbrugge dmvdbrugge force-pushed the no_superfluous_phpdoc_tags_nullable_fix branch from b14eaad to b74dbd3 Compare July 6, 2018 11:20
@julienfalque
Copy link
Member

Note: my commit can be squashed when merging :)

@SpacePossum SpacePossum added the RTM Ready To Merge label Jul 9, 2018
@SpacePossum SpacePossum added this to the 2.12.3 milestone Jul 9, 2018
@SpacePossum SpacePossum changed the title NoSuperfluousPhpdocTagsFixer now handles null in every position... NoSuperfluousPhpdocTagsFixer - handle null in every position Jul 9, 2018
@SpacePossum SpacePossum force-pushed the no_superfluous_phpdoc_tags_nullable_fix branch from 403f61a to 9956636 Compare July 9, 2018 06:37
@SpacePossum SpacePossum merged commit 9956636 into PHP-CS-Fixer:2.12 Jul 9, 2018
SpacePossum added a commit that referenced this pull request Jul 9, 2018
…n (dmvdbrugge, julienfalque)

This PR was squashed before being merged into the 2.12 branch (closes #3884).

Discussion
----------

NoSuperfluousPhpdocTagsFixer - handle null in every position

… instead of last only.

This fixes #3849

Commits
-------

9956636 NoSuperfluousPhpdocTagsFixer - handle null in every position
@SpacePossum
Copy link
Contributor

thanks @dmvdbrugge and @julienfalque 👍

@SpacePossum SpacePossum removed the RTM Ready To Merge label Jul 9, 2018
@dmvdbrugge dmvdbrugge deleted the no_superfluous_phpdoc_tags_nullable_fix branch July 30, 2018 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants