New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PhpdocVarAnnotationCorrectOrderFixer #3881
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 things:
- This needs to ensure priority before
PhpdocVarWithoutNameFixer
. - This should also fix
@type
What is the reasoning behind not fixing |
@dmvdbrugge the alternative for 2 is not a acceptable as we cannot assume some will use
I'm not sure now, maybe we can aim to have /**
- * @param $foo This is foo
+ * @param This $foo us foo
*/ |
Was thinking that as well, removed the suggestion. As for the |
@dmvdbrugge <?php
/**
- * @var FooInterface $foo
+ * @var FooInterface
*/
$foo;
/**
- * @var $bar BarInterface
+ * @var BarInterface
*/
$bar; |
@@ -40,7 +40,7 @@ public function provideFixCases() | |||
$cases = []; | |||
|
|||
foreach (['internalSet', 'imapSet'] as $setStaticAttributeName) { | |||
/** @var $aliases string[] */ | |||
/** @var string[] $aliases */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So nice that it immediately adds value to the project itself 🎉
Thank you @kubawerlos. |
thanks @kubawerlos , very nice to have this one! : D |
Thank you @kubawerlos! 🎉 |
Closes #2159