NamespacesAnalyzer - Optimize performance #3877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of looping on all tokens, even inside the namespace it identified, the analyzer now continues the analysis after the end of the identified namespace, thanks to the fact that namespaces cannot be nested.
keradus
force-pushed
the
namespace_analysis
branch
from
d75a514
to
8321c26
Compare
|
We do push code refactoring to oldest maintained branch, I have changed the target and recreated your branch @stof (force-push) |
keradus
approved these changes
Jul 6, 2018
keradus
changed the title
|
Thank you @stof. |
keradus
added a commit
that referenced
this pull request
Jul 6, 2018
This PR was merged into the 2.12 branch. Discussion ---------- NamespacesAnalyzer - Optimize performance Instead of looping on all tokens, even inside the namespace it identified, the analyzer now continues the analysis after the end of the identified namespace, thanks to the fact that namespaces cannot be nested. When implementing #3876, I compared the NamespacesAnalyzer implementation with `\PhpCsFixer\Fixer\FunctionNotation\NativeFunctionInvocationFixer::getUserDefinedNamespaces`. The NamespacesAnalyzer also identifies the namespace name instead of skipping over it (and returns the global namespace too). But I found out that NativeFunctionInvocationFixer was more optimized, as it was not re-analyzing all tokens inside a namespace. This makes NamespacesAnalyzer implement the same optimization. Commits ------- 8321c26 Optimize the namespaces analyzer
keradus
added a commit
that referenced
this pull request
Jul 6, 2018
…r to remove duplicated code (stof) This PR was merged into the 2.12 branch. Discussion ---------- NativeFunctionInvocationFixer - use the NamespacesAnalyzer to remove duplicated code Instead of maintaining 2 different analyzers to find the beginning and the end of a namespace block, this reuses the existing NamespacesAnalyzer. See #3877 which optimizes it based on existing optimization in the implementation I'm deleting here. Commits ------- b16c2f0 Use the NamespacesAnalyzer in the NativeFunctionInvocationFixer
I was not aware of that. Good to know. |
|
for next MINOR branch we do push only what MINOR is reserved for - features ;) the more similar codebase between versions, the easier to maintain |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of looping on all tokens, even inside the namespace it identified, the analyzer now continues the analysis after the end of the identified namespace, thanks to the fact that namespaces cannot be nested.
When implementing #3876, I compared the NamespacesAnalyzer implementation with
\PhpCsFixer\Fixer\FunctionNotation\NativeFunctionInvocationFixer::getUserDefinedNamespaces. The NamespacesAnalyzer also identifies the namespace name instead of skipping over it (and returns the global namespace too). But I found out that NativeFunctionInvocationFixer was more optimized, as it was not re-analyzing all tokens inside a namespace. This makes NamespacesAnalyzer implement the same optimization.