PhpdocAnnotationWithoutDotFixer - Handle trailing whitespaces #3867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this looks awesome to me, thanks so much :) |
SpacePossum
changed the title
|
(on a side note, if this fixer is about changing text to a sentence without a stop maybe we should unify what we consider a stop (so not only dots), like done here) |
SpacePossum
approved these changes
Jul 11, 2018
ntzm
reviewed
Jul 12, 2018
| */', | ||
| '<?php | ||
| /** | ||
| * @throws \Exception having whitespaces after dot, yet I am fixed. '.' |
There was a problem hiding this comment.
Please add test case for trailing tab character too, as we are using \h
There was a problem hiding this comment.
Sorry, I've missed that. Done.
ntzm
approved these changes
Jul 20, 2018
|
Thank you @kubawerlos. |
keradus
added a commit
that referenced
this pull request
Aug 1, 2018
…es (kubawerlos) This PR was squashed before being merged into the 2.12 branch (closes #3867). Discussion ---------- PhpdocAnnotationWithoutDotFixer - Handle trailing whitespaces Solves #3857 - I guess @SpacePossum will have some more fancy test cases. Commits ------- 3897460 PhpdocAnnotationWithoutDotFixer - Handle trailing whitespaces
kubawerlos
deleted the
fix/phpdoc-annotation-without-dot-fixer-to-handle-trailing-whitespaces
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #3857 - I guess @SpacePossum will have some more fancy test cases.