NoAliasFunctionsFixer - add opt in option for ext-mbstring aliasses #3841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntzm
suggested changes
Jun 28, 2018
| @@ -878,6 +878,13 @@ Choose from the list of available rules: | |||
|
|
|||
| *Risky rule: risky when any of the alias functions are overridden.* | |||
|
|
|||
| Configuration options: | |||
|
|
|||
| - ``sets`` (a subset of ``['@internal', '@IMAP', '@mbreg', '@all']``): list of | |||
There was a problem hiding this comment.
any reasons these options are prefixed with @? It makes sense for native_function_invocation as they can be mixed with actual function names, but in here only @-prefixed options are used
There was a problem hiding this comment.
I like the naming of configuration items to be consistent, so all names describing a set starting with @.
ntzm
approved these changes
Jun 28, 2018
SpacePossum
added a commit
that referenced
this pull request
Jul 2, 2018
…ing aliasses (SpacePossum) This PR was squashed before being merged into the 2.13-dev branch (closes #3841). Discussion ---------- NoAliasFunctionsFixer - add opt in option for ext-mbstring aliasses closes #3840 Commits ------- 5120a08 NoAliasFunctionsFixer - add opt in option for ext-mbstring aliasses
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3840