Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typos in changelog #3829

Merged
merged 1 commit into from Jun 28, 2018
Merged

Fix typos in changelog #3829

merged 1 commit into from Jun 28, 2018

Conversation

mnabialek
Copy link
Contributor

No description provided.

localheinz
localheinz approved these changes Jun 13, 2018
View reviewed changes
Copy link
Member

@localheinz localheinz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@keradus
Copy link
Member

keradus commented Jun 13, 2018

and now I'm wondering.... changelog is autogenerated :D

@mnabialek
Copy link
Contributor Author

@keradus All those typos were also in commits/pull requests :) Just found one today when looking for something so I fixed also others I found

@keradus
Copy link
Member

keradus commented Jun 13, 2018 •
edited by SpacePossum

yeah, I understand that. I am just wondering how to not drop your fixes next time I would regenerate the changelog (which is using, basically, git log under the hood)

@SpacePossum
Copy link
Contributor

nice catch @mnabialek , seems I scored 2 out of 4 ;)
I've to leaving this one to @keradus as I don't know about the implications of the (re)generation of this file.

@keradus keradus added this to the 2.12.2 milestone Jun 13, 2018
@keradus keradus added the RTM Ready To Merge label Jun 13, 2018
@SpacePossum
Copy link
Contributor

Thanks @mnabialek.

@SpacePossum SpacePossum merged commit b0e5da3 into PHP-CS-Fixer:2.12 Jun 28, 2018
SpacePossum added a commit that referenced this pull request Jun 28, 2018
@SpacePossum
minor #3829 Fix typos in changelog (mnabialek)
fab8486 
This PR was squashed before being merged into the 2.12 branch (closes #3829).

Discussion
----------

Fix typos in changelog

Commits
-------

b0e5da3 Fix typos in changelog
@SpacePossum SpacePossum added topic/documentation and removed RTM Ready To Merge labels Jun 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@localheinz localheinz localheinz approved these changes

Assignees
No one assigned
Labels
topic/documentation
Projects
None yet
Milestone
2.12.2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mnabialek @keradus @SpacePossum @localheinz