Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Braces - (re)indenting comment issues #3820

Merged
merged 1 commit into from
Feb 18, 2020
Merged

Braces - (re)indenting comment issues #3820

merged 1 commit into from
Feb 18, 2020

Conversation

SpacePossum
Copy link
Contributor

@SpacePossum SpacePossum commented Jun 8, 2018 •
edited

fixes #3819
fixes #4814

replaces #4700

@SpacePossum SpacePossum removed the WIP label Jun 20, 2018
@keradus keradus changed the base branch from 2.2 to 2.12 July 9, 2018 16:20
@keradus keradus changed the base branch from 2.12 to 2.15 September 4, 2019 10:57
@SpacePossum SpacePossum mentioned this pull request Dec 18, 2019
Closed
@GrahamCampbell
Copy link
Contributor

What's the status here?

@SpacePossum
Copy link
Contributor Author

1,5 year old... I can't say anymore... I really hope someone can have a look...

also the issue itself doesn't sound that hard;
when the braces fixer (re)indents a multi line comment it should not add indentation to empty lines in that comment

@SpacePossum SpacePossum added the status/help wanted Author requests help label Dec 21, 2019
@SpacePossum SpacePossum removed the status/help wanted Author requests help label Feb 15, 2020
@SpacePossum
Copy link
Contributor Author

SpacePossum commented Feb 15, 2020 •
edited

this is good for review

(ping @kubawerlos and @julienfalque )

@julienfalque julienfalque added the RTM Ready To Merge label Feb 16, 2020
@SpacePossum SpacePossum added this to the 2.15.6 milestone Feb 18, 2020
SpacePossum added a commit that referenced this pull request Feb 18, 2020
@SpacePossum
bug #3820 Braces - (re)indenting comment issues (SpacePossum)
864ed4d 
This PR was squashed before being merged into the 2.15 branch (closes #3820).

Discussion
----------

Braces - (re)indenting comment issues

fixes #3819
fixes #4814

replaces #4700

Commits
-------

02fd913 Braces - (re)indenting comment issues
@SpacePossum SpacePossum removed the RTM Ready To Merge label Feb 18, 2020
@SpacePossum SpacePossum merged commit 02fd913 into PHP-CS-Fixer:2.15 Feb 18, 2020
@SpacePossum SpacePossum deleted the 2_2_BracesFixer_comments_with_empty_lines branch February 18, 2020 07:46
This was referenced Feb 18, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienfalque julienfalque julienfalque approved these changes

@kubawerlos kubawerlos kubawerlos approved these changes

Assignees
No one assigned
Labels
kind/bug
Projects
None yet
Milestone
2.15.6
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@SpacePossum @GrahamCampbell @julienfalque @kubawerlos